Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making response headers access case insensitive #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anandkw
Copy link

@anandkw anandkw commented Feb 19, 2023

Converting Concrete class of headers to Case Insensitive TreeMap.
Caveats: null value will not be supported in key now, which in the first, should not be allowed in headers.

@@ -6,7 +6,7 @@

<groupId>com.flipkart.poseidon</groupId>
<artifactId>poseidon</artifactId>
<version>5.14.1</version>
<version>5.14.2-SNAPSHOT</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it a release version, and update all files with this version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will change it to 5.14.2 but before that you don't need to test anything with snapshot version? Also what all files need to be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants